Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incus/aliases: fix completion regression #755

Merged
merged 1 commit into from
Apr 16, 2024
Merged

incus/aliases: fix completion regression #755

merged 1 commit into from
Apr 16, 2024

Conversation

adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Apr 16, 2024 •
edited
Loading 

─❯ incus alias list
+-------+----------------------+
| ALIAS |        TARGET        |
+-------+----------------------+
| shell | exec @ARGS@ -- su -l |
+-------+----------------------+
| st    | storage list         |
+-------+----------------------+

─❯ incus st <TAB>
incus1:  local:

─❯ incus shell <TAB>
incus1:  local:  saving-terrapin

closes: #738

@adamcstephens
incus/aliases: fix completion regression
06949bf 
Signed-off-by: Adam Stephens <adam@valkor.net>
@adamcstephens adamcstephens marked this pull request as ready for review April 16, 2024 13:40
@stgraber
Copy link
Member

Nice, thanks!

@stgraber stgraber merged commit b6bce39 into lxc:main Apr 16, 2024
25 checks passed
@adamcstephens adamcstephens deleted the cmp/aliases branch April 16, 2024 16:54
@gibmat gibmat mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend completion logic to include alias commands
2 participants
@adamcstephens @stgraber