Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of trusted certs in CA mode #221

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Fix handling of trusted certs in CA mode #221

merged 2 commits into from
Nov 5, 2023

Commits on Nov 5, 2023

  1. incusd/auth: Fix handling of trusted certs in CA mode 

    Closes lxc#218

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
    @stgraber
    stgraber committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    d2bb0d8 View commit details
    Browse the repository at this point in the history

  2. tests: Properly test core.trust_ca_certificates 

    The test as it was written was quite incorrect.

core.trust_ca_certificates causes valid certificates to be implictly
trusted and not get a certificate store entry.

But as the test was run immediately after a configuration where
core.trust_ca_certificates was not set, there was a leftover entry in
the trust store which the test was then checking.

This corrects the test by clearing the trust store after the initial
test and by further making sure that when using
core.trust_ca_certificates, no trust store entries get created.

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
    @stgraber
    stgraber committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    9bd8330 View commit details
    Browse the repository at this point in the history