Prevent custom storage volumes of type block to be used more than once #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
monstermunchkin
force-pushed
the
shared-block-volumes
branch
from
8d17454
to
21ce46b
Compare
stgraber
reviewed
Feb 7, 2024
monstermunchkin
force-pushed
the
shared-block-volumes
branch
3 times, most recently
from
a573ce8
to
7ef49e5
Compare
|
@monstermunchkin oops, looks like you need a quick rebase for the API extension. |
monstermunchkin
force-pushed
the
shared-block-volumes
branch
from
7ef49e5
to
d1a1d67
Compare
Fixed. |
stgraber
reviewed
Feb 19, 2024
stgraber
reviewed
Feb 19, 2024
stgraber
reviewed
Feb 19, 2024
|
Just a couple small nits/questions and this will be good to go, thanks! |
Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
The `Update` function returns `map[string]Device` values despite there being a `Devices` type which is the same thing. This commit changes the return types to be `Devices` instead. Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
This validates shared custom block volumes. Such volumes can be attached to profiles only if `security.shared` is `true`. Also, they can only be attached to more than one instance if `security.shared` is `true`. Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
This handles the `security.shared` config key update. If a shared custom storage block volume is attached to a profile, this volume cannot be un-shared. Furthermore, if such a volume is attached to more than one instance, it also cannot be un-shared. Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
…olumes Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
…Config Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
stgraber
force-pushed
the
shared-block-volumes
branch
from
d1a1d67
to
606b833
Compare
stgraber
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.