incusd/storage/lvm: Tweak locking in cluster #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a clustered LVM setup and performing live migrations, the logical volumes must be mappable on both the source and target concurently. This is usually a bad idea and having a volume in that mode also prevents a number of other LVM operations like making snapshots. So rather than keeping all our VM related volumes in shared mode, let's instead only flip them into sharable mode as part of a migration and flip them back to exclusive mode as soon as possible. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
hallyn
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a clustered LVM setup and performing live migrations, the logical volumes must be mappable on both the source and target concurently.
This is usually a bad idea and having a volume in that mode also prevents a number of other LVM operations like making snapshots.
So rather than keeping all our VM related volumes in shared mode, let's instead only flip them into sharable mode as part of a migration and flip them back to exclusive mode as soon as possible.