Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce network integrations (and OVN inter-connect support) #655

Merged
merged 33 commits into from
Mar 25, 2024
Merged

Introduce network integrations (and OVN inter-connect support) #655

merged 33 commits into from
Mar 25, 2024

Conversation

stgraber
Copy link
Member

No description provided.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Mar 24, 2024
@stgraber
Copy link
Member Author

stgraber commented Mar 24, 2024 •
edited
Loading

This is still missing a few things:

  • User documentation
  • Configurable pattern/name for the transit switch
  • Project restriction (list of allowed integrations)

This extends the auth model so I also still need to look at the impact on OpenFGA and whether some model migration logic is needed.

And then this will need new daily tests (as part of Jenkins OVN tests).

@stgraber stgraber force-pushed the ovn-ic branch 6 times, most recently from 05726f6 to 2d3639e Compare March 25, 2024 18:40
@stgraber
Copy link
Member Author

Took care of all the todo items, next is figuring out OpenFGA.

@stgraber stgraber marked this pull request as ready for review March 25, 2024 20:13
@stgraber
api: network_integrations
9096adc 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
shared/api: Add type and target_integration fields to NetworkPeersPost
5d9747b 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/db/cluster: Add networks_integrations
243b1b5 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/db/cluster: Re-generate schema
964aee7 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/db/cluster: Add generated DB code for network integrations
8eab1bc 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/db: Update network peer DB query functions
612cd78 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
client: Add check for network_integrations in CreateNetworkPeer
c59cf79 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incus/network/peer: Add support for network peer types
833ea14 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
shared/api: Add network integrations
44f4c72 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
client: Add network integration functions
3938689 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incus/network: Introduce support for integrations
f85e5c2 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/auth: Add network integration functions
32df268 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
shared/api: Add lifecycle events for network integrations
996d943 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/lifecycle: Add network integration events
c8a7ecc 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd: Add network integration API
20ac73f 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/db: Add GetNetworkPeersURLByIntegration
7126922 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/network_integration: Add UsedBy field
b02a646 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/network_integrations: Add validator
ecde076 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/network/ovn: Add support for peering with OVN IC
baaeeb4 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/project: Add restricted.networks.integrations
3a145b6 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/project: Add NetworkIntegrationAllowed
2debae2 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/network/integrations: Respect project restrictions
9283edc 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
incusd/network/ovn: Add support for integration restrictions
59fdf33 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/auth/openfga: Update the model
7f806fc 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/auth/openfga: Update the generated model
3788589 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/auth/openfga: Handle model updates
8754d52 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd: Remove openfga.store.model_id
4d9166c 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
incusd/db/cluster: Remove openfga.store.model_id
fed766f 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
doc/ovn_peers: Add remote peering
0a9e669 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
doc: Add documentation for network integrations
d8cc514 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
doc/rest-api: Refresh swagger YAML
5710e83 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
i18n: Update translation templates
4587f85 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@stgraber
doc: Update configs
886e616 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: Luizalabs (https://luizalabs.com)
@hallyn hallyn merged commit db3115e into lxc:main Mar 25, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallyn hallyn hallyn approved these changes

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stgraber @hallyn