Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding USB support to incus info --resources #723

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Adding USB support to incus info --resources #723

merged 2 commits into from
Apr 2, 2024

Conversation

RaviTriv
Copy link
Contributor

@RaviTriv RaviTriv commented Apr 2, 2024

This PR is in reference to #702 . It adds Usb information to cmd output of resources.

@RaviTriv RaviTriv marked this pull request as ready for review April 2, 2024 00:08
@RaviTriv RaviTriv requested a review from stgraber as a code owner April 2, 2024 00:08
@stgraber
Copy link
Member

stgraber commented Apr 2, 2024

Reviewed and fixed a few minor things:

  • Split code change and translations into two commits
  • Added bug reference to code commit and re-titled it
  • Reworded things slightly so header is USB devices, single device is USB device and individual entries are just Device X.

RaviTriv and others added 2 commits April 1, 2024 22:11
@RaviTriv @stgraber
incus/info: Add USB info to --resources
c374798 
Closes #702

Signed-off-by: RaviTriv <trivediravi561@gmail.com>
@stgraber
i18n: Update translation templates
bbd91e8 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber stgraber merged commit e6809f8 into lxc:main Apr 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaviTriv @stgraber