Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very seriously reworks the server-side instance move logic.
It had been slowly grown over the years meaning that each addition didn't necessarily fit well with the previous ones.
The new logic is basically split into two main stage:
The instance migration part then got a major overhaul too and now will basically do:
This should basically allow handling requests that can change one or more of:
As well as supporting the additional properties controlling live migration, whether to retain snapshots and whether to override some specific parts of the instance configuration.
Closes #589
Closes #695
Closes #590
Closes #566