Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incus/snapshot: Add yaml support for snapshot create #767

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

awalvie
Copy link
Contributor

@awalvie awalvie commented Apr 17, 2024

Part of #741

@awalvie awalvie requested a review from stgraber as a code owner April 17, 2024 18:26
@awalvie
Copy link
Contributor Author

awalvie commented Apr 17, 2024

The failing test seems to be unrelated the the PR. Can we re-trigger it?

@stgraber stgraber force-pushed the add-yaml-support-for-snapshot-create branch from ca4883e to bcfb945 Compare April 17, 2024 19:09
cmd/incus/snapshot.go Outdated Show resolved Hide resolved
cmd/incus/snapshot.go Outdated Show resolved Hide resolved
@awalvie awalvie force-pushed the add-yaml-support-for-snapshot-create branch from bcfb945 to 063f6fc Compare April 18, 2024 07:55
Part of lxc#741

Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com>
Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com>
@awalvie awalvie force-pushed the add-yaml-support-for-snapshot-create branch from b5a1827 to c8cffe1 Compare April 18, 2024 09:00
@awalvie
Copy link
Contributor Author

awalvie commented Apr 18, 2024

Ready for next round of reviews!

@stgraber stgraber merged commit b31de22 into lxc:main Apr 18, 2024
25 checks passed
@awalvie awalvie deleted the add-yaml-support-for-snapshot-create branch April 18, 2024 14:23
@awalvie awalvie changed the title Add yaml support for snapshot create incus/snapshot: Add yaml support for snapshot create Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants