Require migration.stateful for containers too

[Abhiram824]

No description provided.

[stgraber]

API extensions should always be appended to the existing list, not added at the top or middle of the files.

[stgraber]

I left a few more comments in line. General structure looks good so it's just about fixing a bunch of small things.

Also make sure to run both gofmt -s -w ./ and make static-analysis to fix some formatting issues and then make sure that there's nothing else that needs fixing.

[Abhiram824]

I left a few more comments in line. General structure looks good so it's just about fixing a bunch of small things.

Also make sure to run both gofmt -s -w ./ and make static-analysis to fix some formatting issues and then make sure that there's nothing else that needs fixing.

I ran both commands. make static-analysis was able to run for everything except for rest-api-up-to-date, but since there were no changes to doc/rest-api.yaml I just moved on for now

[stgraber]

I ran both commands. make static-analysis was able to run for everything except for rest-api-up-to-date, but since there were no changes to doc/rest-api.yaml I just moved on for now

It's telling you that there should be a change to doc/rest-api.yaml.

Run make update-api, that will generate the applicable change to doc/rest-api.yaml, then add that in a new commit title: doc/rest-api: Refresh swagger YAML

[stgraber]

Looking into that one now.

[stgraber]

Changes I made:

• Rebased on current main branch
• Moved changes to generated files into their own commit
• Rebased the fix commits into the main commits
• Slightly reworded the error messages
• Added bug reference to commit

Now just waiting to see if Github Actions catch anything else :)

[stgraber]

Also had to move the API extension to the bottom of the file.