incus/cluster: Add customizable columns to list #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
changed the title
presztak
suggested changes
Apr 24, 2024
cmd/incus/cluster.go
Outdated
| @@ -19,10 +19,17 @@ import ( | |||
| "github.com/lxc/incus/v6/shared/util" | |||
| ) | |||
|
|
|||
|
|
|||
cmd/incus/cluster.go
Outdated
| type cmdCluster struct { | ||
| global *cmdGlobal | ||
| } | ||
|
|
||
|
|
cmd/incus/cluster.go
Outdated
| flagFormat string | ||
| flagAllProjects bool | ||
|
|
cmd/incus/cluster.go
Outdated
| // Show. | ||
| type cmdClusterShow struct { | ||
| global *cmdGlobal | ||
| cluster *cmdCluster | ||
|
|
cmd/incus/cluster.go
Outdated
| return cli.RenderTable(c.flagFormat, header, data, members) | ||
| } | ||
|
|
||
|
|
||
|
|
cmd/incus/cluster.go
Outdated
| @@ -292,6 +406,7 @@ func (c *cmdClusterInfo) Run(cmd *cobra.Command, args []string) error { | |||
| return err | |||
| } | |||
|
|
|||
|
|
|||
cmd/incus/cluster.go
Outdated
|
|
||
| for _, columnRune := range columnEntry { | ||
| column, ok := columnsShorthandMap[columnRune] | ||
| if ok { |
There was a problem hiding this comment.
You can simplify this if..else:
if ok {
columns = append(columns, column)
}
return nil, fmt.Errorf(i18n.G("Unknown column shorthand char '%c' in '%s'"), columnRune, columnEntry)
Closes lxc#721 Signed-off-by: Anish Mankal <anish.mankal@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
|
@Anish-M I've added couple of minor comments. In addition:
Thanks! |
|
I've done the following:
On top of those small easy fixes, I also noticed that you had put mention of filtering in the description but |
|
@presztak thanks for the review! I think you caught all the same stuff I did :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add customizable columns to incus cluster list