Add PCI support to incus info --resources #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes lxc#704 Signed-off-by: sharkman424 <joshuadierker@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
|
Looking into this one now, I did:
|
stgraber
changed the title
Thank you, can you tell me how to remove commits from a PR so I can avoid this in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 879954b closes #704
Signed off by: Joshua Dierker joshuadierker@gmail.com
I am still unable to run make static-analysis locally due to shellcheck error.
Also, I get a runtime error locally when I do incus info --resources. It happens on the main branch, at the chassis info section. It is likely something with my environment but I wanted to bring it to your attention. See image below
