Skip to content

Commit

Permalink
drop useless apparmor denies
Browse files Browse the repository at this point in the history
mem and kmem are really in /dev, so this does us no good.

Signed-off-by: Tycho Andersen <tycho@tycho.ws>
  • Loading branch information
tych0 authored and stgraber committed Oct 4, 2017
1 parent 1cdad20 commit 18103c3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions config/apparmor/abstractions/container-base
Expand Up @@ -72,8 +72,6 @@

# block some other dangerous paths
deny @{PROC}/kcore rwklx,
deny @{PROC}/kmem rwklx,
deny @{PROC}/mem rwklx,
deny @{PROC}/sysrq-trigger rwklx,

# deny writes in /sys except for /sys/fs/cgroup, also allow
Expand Down
2 changes: 0 additions & 2 deletions config/apparmor/abstractions/container-base.in
Expand Up @@ -72,8 +72,6 @@

# block some other dangerous paths
deny @{PROC}/kcore rwklx,
deny @{PROC}/kmem rwklx,
deny @{PROC}/mem rwklx,
deny @{PROC}/sysrq-trigger rwklx,

# deny writes in /sys except for /sys/fs/cgroup, also allow
Expand Down
2 changes: 1 addition & 1 deletion src/tests/aa.c
Expand Up @@ -105,7 +105,7 @@ char *files_to_allow[] = { "/sys/class/net/lo/ifalias",
"/proc/sys/kernel/shmmax",
NULL };

char *files_to_deny[] = { "/proc/mem", "/proc/kmem",
char *files_to_deny[] = {
"/sys/kernel/uevent_helper",
"/proc/sys/fs/file-nr",
"/sys/kernel/mm/ksm/pages_to_scan",
Expand Down

0 comments on commit 18103c3

Please sign in to comment.