Skip to content

Commit

Permalink
do not set insecure passwords
Browse files Browse the repository at this point in the history
Signed-off-by: Evgeni Golov <evgeni@debian.org>
  • Loading branch information
evgeni committed Dec 15, 2016
1 parent 154a741 commit 37fbf44
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 47 deletions.
29 changes: 0 additions & 29 deletions templates/lxc-busybox.in
Expand Up @@ -330,35 +330,6 @@ configure_busybox()
chmod +s $rootfs/bin/passwd
touch $rootfs/etc/shadow

# setting passwd for root
CHPASSWD_FILE=$rootfs/root/chpasswd.sh

cat <<EOF >$CHPASSWD_FILE
echo "setting root password to \"root\""
mount -n --bind /lib $rootfs/lib
if [ \$? -ne 0 ]; then
echo "Failed bind-mounting /lib at $rootfs/lib"
exit 1
fi
chroot $rootfs chpasswd <<EOFF 2>/dev/null
root:root
EOFF
if [ \$? -ne 0 ]; then
echo "Failed to change root password"
exit 1
fi
umount $rootfs/lib
EOF

lxc-unshare -s MOUNT -- /bin/sh < $CHPASSWD_FILE
rm $CHPASSWD_FILE

return 0
}

Expand Down
1 change: 0 additions & 1 deletion templates/lxc-opensuse.in
Expand Up @@ -116,7 +116,6 @@ EOF
touch $rootfs/etc/sysconfig/kernel

echo "Please change root-password !"
echo "root:root" | chpasswd -R $rootfs

return 0
}
Expand Down
8 changes: 3 additions & 5 deletions templates/lxc-oracle.in
Expand Up @@ -462,12 +462,10 @@ EOF
fi
fi

# add oracle user, set root password
# add oracle user
chroot $container_rootfs useradd -m -s /bin/bash oracle
echo "oracle:oracle" | chroot $container_rootfs chpasswd
echo "root:root" | chroot $container_rootfs chpasswd
printf "Added container user:\033[1moracle\033[0m password:\033[1moracle\033[0m\n"
printf "Added container user:\033[1mroot\033[0m password:\033[1mroot\033[0m\n"
printf "Added container user:\033[1moracle\033[0m\n"
printf "Added container user:\033[1mroot\033[0m\n"
}

# create the container's lxc config file
Expand Down
3 changes: 0 additions & 3 deletions templates/lxc-plamo.in
Expand Up @@ -186,9 +186,6 @@ configure_plamo() {
# glibc configure
mv $rootfs/etc/ld.so.conf{.new,}
chroot $rootfs ldconfig
# root password
echo "Setting root password to 'root'..."
echo "root:root" | chroot $rootfs chpasswd
echo "Please change root password!"
ed - $rootfs/etc/rc.d/rc.S <<- "EOF"
/^mount -w -n -t proc/;/^mkdir \/dev\/shm/-1d
Expand Down
4 changes: 0 additions & 4 deletions templates/lxc-slackware.in
Expand Up @@ -471,10 +471,6 @@ sed -i 's/.*genpowerfail.*//' $rootfs/etc/inittab
# add a message to rc.local that confirms successful container startup
echo "echo ; echo \"* container $name started. *\" ; echo" >> $rootfs/etc/rc.d/rc.local

# set a default combination for the luggage
echo "root:root" | chroot $rootfs chpasswd
echo "Root default password is 'root', please change it!"

# borrow the time configuration from the local machine
cp -a /etc/localtime $rootfs/etc/localtime

Expand Down
8 changes: 3 additions & 5 deletions templates/lxc-sparclinux.in
Expand Up @@ -296,12 +296,10 @@ EOF
echo "Timezone in container is not configured. Adjust it manually."
fi

# add oracle user, set root password
# add oracle user
chroot $container_rootfs useradd -m -s /bin/bash oracle
echo "oracle:oracle" | chroot $container_rootfs chpasswd
echo "root:root" | chroot $container_rootfs chpasswd
printf "Added container user:\033[1moracle\033[0m password:\033[1moracle\033[0m\n"
printf "Added container user:\033[1mroot\033[0m password:\033[1mroot\033[0m\n"
printf "Added container user:\033[1moracle\033[0m\n"
printf "Added container user:\033[1mroot\033[0m\n"
}

# create the container's lxc config file
Expand Down

0 comments on commit 37fbf44

Please sign in to comment.