Skip to content

Commit

Permalink
coverity: #1425739
Browse files Browse the repository at this point in the history
check snprintf() return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
  • Loading branch information
Christian Brauner committed Dec 15, 2017
1 parent 29d5060 commit 70a2599
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions src/tests/snapshot.c
Expand Up @@ -55,6 +55,10 @@ static void try_to_remove(void)

int main(int argc, char *argv[])
{
int i, n, ret;
char path[1024];
struct stat sb;
struct lxc_snapshot *s;
struct lxc_container *c, *c2 = NULL;
char *template = "busybox";

Expand Down Expand Up @@ -89,19 +93,18 @@ int main(int argc, char *argv[])
}

// rootfs should be ${lxcpath}${lxcname}/snaps/snap0/rootfs
struct stat sb;
int ret;
char path[1024];
snprintf(path, 1024, "%s/%s/snaps/snap0/rootfs", lxc_get_global_config_item("lxc.lxcpath"), MYNAME);
ret = snprintf(path, 1024, "%s/%s/snaps/snap0/rootfs", lxc_get_global_config_item("lxc.lxcpath"), MYNAME);
if (ret < 0 || (size_t)ret >= 1024) {
fprintf(stderr, "%s: %d: failed to create string\n", __FILE__, __LINE__);
goto err;
}

ret = stat(path, &sb);
if (ret != 0) {
fprintf(stderr, "%s: %d: snapshot was not actually created\n", __FILE__, __LINE__);
goto err;
}

struct lxc_snapshot *s;
int i, n;

n = c->snapshot_list(c, &s);
if (n < 1) {
fprintf(stderr, "%s: %d: failed listing containers\n", __FILE__, __LINE__);
Expand Down

0 comments on commit 70a2599

Please sign in to comment.