only execute last test when we are a pty

Signed-off-by: Christian Brauner <christian.brauner@mailbox.org>
lxc · Apr 13, 2016 · 804bd6e · 804bd6e
1 parent c87524b
commit 804bd6e
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/tests/lxc-test-lxc-attach b/src/tests/lxc-test-lxc-attach
@@ -190,14 +190,16 @@ fi
 
 rm -f $out $err
 
-# Test whether logging pty output to a file works.
-trap "rm -f /tmp/ptylog" EXIT INT QUIT PIPE
-lxc-attach -n busy -L /tmp/ptylog -- hostname || FAIL "to allocate or setup pty"
-if [ $allocate_pty == "pty" ] && [ ! -s /tmp/ptylog ]; then
-        FAIL "lxc-attach -n busy -L /tmp/ptylog -- hostname"
-fi
+if [ $allocate_pty = "pty" ]; then
+	# Test whether logging pty output to a file works.
+	trap "rm -f /tmp/ptylog" EXIT INT QUIT PIPE
+	lxc-attach -n busy -L /tmp/ptylog -- hostname || FAIL "to allocate or setup pty"
+	if [ ! -s /tmp/ptylog ]; then
+		FAIL "lxc-attach -n busy -L /tmp/ptylog -- hostname"
+	fi
 
-rm -f /tmp/ptylog
+	rm -f /tmp/ptylog
+fi
 
 lxc-destroy -n busy -f