Skip to content

Commit

Permalink
Only use clear_config_item for lists
Browse files Browse the repository at this point in the history
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
  • Loading branch information
stgraber committed Jan 28, 2015
1 parent fcdc3e5 commit 8d19ce7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions src/python-lxc/lxc/__init__.py
Expand Up @@ -97,8 +97,12 @@ def __setattr__(self, key, value):
return self.__set_network_item(self.props[key], value)

def __clear_network_item(self, key):
return self.container.clear_config_item("lxc.network.%s.%s" % (
self.index, key))
if key in ("ipv4", "ipv6"):
return self.container.clear_config_item("lxc.network.%s.%s" % (
self.index, key))
else:
return self.container.set_config_item("lxc.network.%s.%s" % (
self.index, key), "")

def __get_network_item(self, key):
return self.container.get_config_item("lxc.network.%s.%s" % (
Expand Down
2 changes: 1 addition & 1 deletion src/tests/get_item.c
Expand Up @@ -249,7 +249,7 @@ int main(int argc, char *argv[])
ret = 1;
goto out;
}
if (!c->clear_config_item(c, "lxc.network.0.ipv4.gateway")) {
if (!c->set_config_item(c, "lxc.network.0.ipv4.gateway", "")) {
fprintf(stderr, "%d: failed clearing ipv4.gateway\n", __LINE__);
ret = 1;
goto out;
Expand Down

0 comments on commit 8d19ce7

Please sign in to comment.