confile: cleanup get_config_net_ipv4_address()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
lxc · Dec 15, 2020 · a1fd71e · a1fd71e
1 parent 42ceb01
commit a1fd71e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/lxc/confile.c b/src/lxc/confile.c
@@ -5584,13 +5584,14 @@ static int get_config_net_ipv4_address(const char *key, char *retv, int inlen,
 		memset(retv, 0, inlen);
 
 	if (!netdev)
-		return -1;
+		return ret_errno(EINVAL);
 
 	listlen = lxc_list_len(&netdev->ipv4);
 
 	lxc_list_for_each(it, &netdev->ipv4) {
 		struct lxc_inetdev *i = it->elem;
-		inet_ntop(AF_INET, &i->addr, buf, sizeof(buf));
+		if (!inet_ntop(AF_INET, &i->addr, buf, sizeof(buf)))
+			return -errno;
 		strprint(retv, inlen, "%s/%u%s", buf, i->prefix,
 			 (listlen-- > 1) ? "\n" : "");
 	}