Skip to content

Commit

Permalink
attach: close lsm label file descriptor
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
  • Loading branch information
Christian Brauner committed Dec 8, 2016
1 parent 2669225 commit a2d6fe8
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/lxc/attach.c
Expand Up @@ -932,7 +932,8 @@ int lxc_attach(const char* name, const char* lxcpath, lxc_attach_exec_t exec_fun

/* Open LSM fd and send it to child. */
if ((options->namespaces & CLONE_NEWNS) && (options->attach_flags & LXC_ATTACH_LSM) && init_ctx->lsm_label) {
int on_exec, labelfd;
int on_exec;
int labelfd = -1;
on_exec = options->attach_flags & LXC_ATTACH_LSM_EXEC ? 1 : 0;
/* Open fd for the LSM security module. */
labelfd = lsm_openat(procfd, attached_pid, on_exec);
Expand All @@ -941,12 +942,15 @@ int lxc_attach(const char* name, const char* lxcpath, lxc_attach_exec_t exec_fun

/* Send child fd of the LSM security module to write to. */
ret = lxc_abstract_unix_send_fd(ipc_sockets[0], labelfd, NULL, 0);
close(labelfd);
if (ret <= 0) {
ERROR("Intended to send file descriptor %d: %s.", labelfd, strerror(errno));
goto on_error;
}
}

if (procfd >= 0)
close(procfd);
/* Now shut down communication with child, we're done. */
shutdown(ipc_sockets[0], SHUT_RDWR);
close(ipc_sockets[0]);
Expand Down

0 comments on commit a2d6fe8

Please sign in to comment.