Skip to content

Commit

Permalink
log: dont create log file for fuzz builds
Browse files Browse the repository at this point in the history
Fixes: #3730
Fixes: google/oss-fuzz#5509
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
  • Loading branch information
Christian Brauner committed Mar 26, 2021
1 parent 27df252 commit a30a4ef
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/lxc/log.c
Expand Up @@ -513,8 +513,9 @@ static int build_dir(const char *name)

static int log_open(const char *name)
{
int newfd = -EBADF;
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
__do_close int fd = -EBADF;
int newfd;

fd = lxc_unpriv(open(name, O_CREAT | O_WRONLY | O_APPEND | O_CLOEXEC, 0660));
if (fd < 0)
Expand All @@ -526,7 +527,7 @@ static int log_open(const char *name)
newfd = fcntl(fd, F_DUPFD_CLOEXEC, STDERR_FILENO);
if (newfd < 0)
return log_error_errno(-errno, errno, "Failed to dup log fd %d", fd);

#endif /* !FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION */
return newfd;
}

Expand Down Expand Up @@ -821,7 +822,6 @@ int lxc_log_set_file(int *fd, const char *fname)
*fd = log_open(fname);
if (*fd < 0)
return -errno;

return 0;
}

Expand Down

0 comments on commit a30a4ef

Please sign in to comment.