Skip to content

Commit

Permalink
use more accurate bdev_type name for rootfs.bdev
Browse files Browse the repository at this point in the history
It'll make future code reading easier.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
  • Loading branch information
hallyn committed Apr 2, 2016
1 parent 984bd62 commit b3b8c97
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/lxc/bdev/bdev.c
Expand Up @@ -858,8 +858,8 @@ static const struct bdev_type *bdev_query(struct lxc_conf *conf, const char *src
{
int i;

if (conf->rootfs.bdev)
return get_bdev_by_name(conf->rootfs.bdev);
if (conf->rootfs.bdev_type)
return get_bdev_by_name(conf->rootfs.bdev_type);

for (i = 0; i < numbdevs; i++) {
int r;
Expand Down
2 changes: 1 addition & 1 deletion src/lxc/conf.c
Expand Up @@ -4142,7 +4142,7 @@ void lxc_conf_free(struct lxc_conf *conf)
free(conf->console.log_path);
free(conf->console.path);
free(conf->rootfs.mount);
free(conf->rootfs.bdev);
free(conf->rootfs.bdev_type);
free(conf->rootfs.options);
free(conf->rootfs.path);
free(conf->logfile);
Expand Down
4 changes: 2 additions & 2 deletions src/lxc/conf.h
Expand Up @@ -220,13 +220,13 @@ struct lxc_console {
* @path : the rootfs source (directory or device)
* @mount : where it is mounted
* @options : mount options
* @bev : optional backing store type
* @bev_type : optional backing store type
*/
struct lxc_rootfs {
char *path;
char *mount;
char *options;
char *bdev;
char *bdev_type;
};

/*
Expand Down
8 changes: 4 additions & 4 deletions src/lxc/confile.c
Expand Up @@ -73,7 +73,7 @@ static int config_fstab(const char *, const char *, struct lxc_conf *);
static int config_rootfs(const char *, const char *, struct lxc_conf *);
static int config_rootfs_mount(const char *, const char *, struct lxc_conf *);
static int config_rootfs_options(const char *, const char *, struct lxc_conf *);
static int config_rootfs_bdev(const char *, const char *, struct lxc_conf *);
static int config_rootfs_bdev_type(const char *, const char *, struct lxc_conf *);
static int config_pivotdir(const char *, const char *, struct lxc_conf *);
static int config_utsname(const char *, const char *, struct lxc_conf *);
static int config_hook(const char *, const char *, struct lxc_conf *lxc_conf);
Expand Down Expand Up @@ -132,7 +132,7 @@ static struct lxc_config_t config[] = {
{ "lxc.mount", config_fstab },
{ "lxc.rootfs.mount", config_rootfs_mount },
{ "lxc.rootfs.options", config_rootfs_options },
{ "lxc.rootfs.bdev", config_rootfs_bdev },
{ "lxc.rootfs.bdev", config_rootfs_bdev_type },
{ "lxc.rootfs", config_rootfs },
{ "lxc.pivotdir", config_pivotdir },
{ "lxc.utsname", config_utsname },
Expand Down Expand Up @@ -1856,15 +1856,15 @@ static int config_rootfs_options(const char *key, const char *value,
return config_string_item(&lxc_conf->rootfs.options, value);
}

static int config_rootfs_bdev(const char *key, const char *value,
static int config_rootfs_bdev_type(const char *key, const char *value,
struct lxc_conf *lxc_conf)
{
if (!is_valid_bdev_type(value)) {
ERROR("Bad bdev type for %s: %s", key, value);
return -1;
}

return config_string_item(&lxc_conf->rootfs.bdev, value);
return config_string_item(&lxc_conf->rootfs.bdev_type, value);
}

static int config_pivotdir(const char *key, const char *value,
Expand Down

0 comments on commit b3b8c97

Please sign in to comment.