Skip to content

Commit

Permalink
tree-wide: this is all rather TODO than FIXME
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
  • Loading branch information
Christian Brauner authored and stgraber committed May 14, 2020
1 parent 52d2862 commit b467fc3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/lxc/attach_options.h
Expand Up @@ -26,7 +26,7 @@ enum {

/* The following are off by default: */
LXC_ATTACH_REMOUNT_PROC_SYS = 0x00010000, /*!< Remount /proc filesystem */
LXC_ATTACH_LSM_NOW = 0x00020000, /*!< FIXME: unknown */
LXC_ATTACH_LSM_NOW = 0x00020000, /*!< TODO: currently unused */
/* Set PR_SET_NO_NEW_PRIVS to block execve() gainable privileges. */
LXC_ATTACH_NO_NEW_PRIVS = 0x00040000, /*!< PR_SET_NO_NEW_PRIVS */
LXC_ATTACH_TERMINAL = 0x00080000, /*!< Allocate new terminal for attached process. */
Expand Down
8 changes: 4 additions & 4 deletions src/lxc/lsm/apparmor.c
Expand Up @@ -122,7 +122,7 @@ static const char AA_PROFILE_BASE[] =
" deny /sys/kernel/debug/{,**} rwklx,\n"
"\n"
" # allow paths to be made slave, shared, private or unbindable\n"
" # FIXME: This currently doesn't work due to the apparmor parser treating those as allowing all mounts.\n"
" # TODO: This currently doesn't work due to the apparmor parser treating those as allowing all mounts.\n"
"# mount options=(rw,make-slave) -> **,\n"
"# mount options=(rw,make-rslave) -> **,\n"
"# mount options=(rw,make-shared) -> **,\n"
Expand Down Expand Up @@ -343,7 +343,7 @@ static const char AA_PROFILE_NESTING_BASE[] =
" mount /var/lib/lxd/shmounts/ -> /var/lib/lxd/shmounts/,\n"
" mount options=bind /var/lib/lxd/shmounts/** -> /var/lib/lxd/**,\n"
"\n"
" # FIXME: There doesn't seem to be a way to ask for:\n"
" # TODO: There doesn't seem to be a way to ask for:\n"
" # mount options=(ro,nosuid,nodev,noexec,remount,bind),\n"
" # as we always get mount to $cdir/proc/sys with those flags denied\n"
" # So allow all mounts until that is straightened out:\n"
Expand Down Expand Up @@ -538,7 +538,7 @@ static inline char *apparmor_namespace(const char *ctname, const char *lxcpath)
return full;
}

/* FIXME: This is currently run only in the context of a constructor (via the
/* TODO: This is currently run only in the context of a constructor (via the
* initial lsm_init() called due to its __attribute__((constructor)), so we
* do not have ERROR/... macros available, so there are some fprintf(stderr)s
* in there.
Expand All @@ -560,7 +560,7 @@ static bool check_apparmor_parser_version()
lxc_pclose(parserpipe);
/* We stay silent for now as this most likely means the shell
* lxc_popen executed failed to find the apparmor_parser binary.
* See the FIXME comment above for details.
* See the TODO comment above for details.
*/
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lxc/lxccontainer.h
Expand Up @@ -90,7 +90,7 @@ struct lxc_container {
* \private
* Container configuration.
*
* \internal FIXME: do we want the whole lxc_handler?
* \internal TODO: do we want the whole lxc_handler?
*/
struct lxc_conf *lxc_conf;

Expand Down

0 comments on commit b467fc3

Please sign in to comment.