fix leak when a veth.pair name is specified

Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Acked-by: Stéphane Graber <stgraber@ubuntu.com>
lxc · Nov 5, 2013 · c9bb9a8 · c9bb9a8
1 parent 8585f20
commit c9bb9a8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/src/lxc/conf.c b/src/lxc/conf.c
@@ -3308,6 +3308,8 @@ static void lxc_remove_nic(struct lxc_list *it)
 		free(netdev->link);
 	if (netdev->name)
 		free(netdev->name);
+	if (netdev->type == LXC_NET_VETH && netdev->priv.veth_attr.pair)
+		free(netdev->priv.veth_attr.pair);
 	if (netdev->upscript)
 		free(netdev->upscript);
 	if (netdev->hwaddr)

diff --git a/src/lxc/confile.c b/src/lxc/confile.c
@@ -453,19 +453,7 @@ static struct lxc_netdev *network_netdev(const char *key, const char *value,
 
 static int network_ifname(char **valuep, const char *value)
 {
-	if (strlen(value) >= IFNAMSIZ) {
-		ERROR("interface name '%s' too long (>%d)\n",
-		value, IFNAMSIZ - 1);
-		return -1;
-	}
-
-	*valuep = strdup(value);
-	if (!*valuep) {
-		ERROR("failed to dup string '%s'", value);
-		return -1;
-	}
-
-	return 0;
+	return config_string_item_max(valuep, value, IFNAMSIZ);
 }
 
 #ifndef MACVLAN_MODE_PRIVATE