Skip to content

Commit

Permalink
confile: lxc_listconfigs -> lxc_list_config_items
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
  • Loading branch information
Christian Brauner committed Aug 10, 2017
1 parent 3aea1a7 commit cfc6762
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 26 deletions.
42 changes: 21 additions & 21 deletions src/lxc/confile.c
Expand Up @@ -366,27 +366,6 @@ extern struct lxc_config_t *lxc_getconfig(const char *key)
return NULL;
}

int lxc_listconfigs(char *retv, int inlen)
{
size_t i;
int len;
int fulllen = 0;

if (!retv)
inlen = 0;
else
memset(retv, 0, inlen);

for (i = 0; i < config_size; i++) {
char *s = config[i].name;
if (s[strlen(s) - 1] == '.')
continue;
strprint(retv, inlen, "%s\n", s);
}

return fulllen;
}

static int set_config_net(const char *key, const char *value,
struct lxc_conf *lxc_conf, void *data)
{
Expand Down Expand Up @@ -4506,3 +4485,24 @@ static int get_config_net_ipv6_address(const char *key, char *retv, int inlen,

return fulllen;
}

int lxc_list_config_items(char *retv, int inlen)
{
size_t i;
int len;
int fulllen = 0;

if (!retv)
inlen = 0;
else
memset(retv, 0, inlen);

for (i = 0; i < config_size; i++) {
char *s = config[i].name;
if (s[strlen(s) - 1] == '.')
continue;
strprint(retv, inlen, "%s\n", s);
}

return fulllen;
}
2 changes: 1 addition & 1 deletion src/lxc/confile.h
Expand Up @@ -55,7 +55,7 @@ extern struct lxc_config_t *lxc_getconfig(const char *key);
*/
extern int lxc_list_net(struct lxc_conf *c, const char *key, char *retv,
int inlen);
extern int lxc_listconfigs(char *retv, int inlen);
extern int lxc_list_config_items(char *retv, int inlen);
extern int lxc_config_read(const char *file, struct lxc_conf *conf, bool from_include);
extern int append_unexp_config_line(const char *line, struct lxc_conf *conf);

Expand Down
1 change: 0 additions & 1 deletion src/lxc/confile_utils.c
Expand Up @@ -680,4 +680,3 @@ bool parse_limit_value(const char **value, unsigned long *res)

return true;
}

2 changes: 1 addition & 1 deletion src/lxc/lxccontainer.c
Expand Up @@ -2249,7 +2249,7 @@ WRAP_API_1(char *, lxcapi_get_running_config_item, const char *)
static int do_lxcapi_get_keys(struct lxc_container *c, const char *key, char *retv, int inlen)
{
if (!key)
return lxc_listconfigs(retv, inlen);
return lxc_list_config_items(retv, inlen);
/*
* Support 'lxc.net.<idx>', i.e. 'lxc.net.0'
* This is an intelligent result to show which keys are valid given
Expand Down
4 changes: 2 additions & 2 deletions src/tests/config_jump_table.c
Expand Up @@ -38,15 +38,15 @@ int main(int argc, char *argv[])
int fulllen = 0, inlen = 0, ret = EXIT_FAILURE;
char *key, *keys, *saveptr = NULL;

fulllen = lxc_listconfigs(NULL, inlen);
fulllen = lxc_list_config_items(NULL, inlen);

keys = malloc(sizeof(char) * fulllen + 1);
if (!keys) {
lxc_error("%s\n", "failed to allocate memory");
exit(ret);
}

if (lxc_listconfigs(keys, fulllen) != fulllen) {
if (lxc_list_config_items(keys, fulllen) != fulllen) {
lxc_error("%s\n", "failed to retrieve configuration keys");
goto on_error;
}
Expand Down

0 comments on commit cfc6762

Please sign in to comment.