Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc-update-config breaks lxc.logfile settings #3369

Closed
matthijskooijman opened this issue Apr 10, 2020 · 2 comments · Fixed by #3370
Closed

lxc-update-config breaks lxc.logfile settings #3369

matthijskooijman opened this issue Apr 10, 2020 · 2 comments · Fixed by #3370

Comments

@matthijskooijman
Copy link
Contributor

There is a typo in the script:

lxc/src/lxc/cmd/lxc-update-config.in

Line 77 in b7b0264

-e 's/\([[:blank:]*]\|#*\)\(lxc\.logfile\)\([[:blank:]*]\|=\)/1lxc\.log\.file\3/g' \

It has 1 where it should have \1 in the replacement. Running the script on a file with the lxc.logfile directive produces:

-lxc.logfile = /var/log/lxc/template.log
+1lxc.log.file = /var/log/lxc/template.log
stgraber added a commit to stgraber/lxc that referenced this issue Apr 10, 2020
@stgraber
lxc-update-config: Fix bad handling of lxc.logfile
71310cc 
Closes lxc#3369

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@stgraber stgraber mentioned this issue Apr 10, 2020
Merged
@stgraber
Copy link
Member

Sent a fix

@matthijskooijman
Copy link
Contributor Author

Thanks :-)

stgraber added a commit that referenced this issue Apr 10, 2020
@stgraber
lxc-update-config: Fix bad handling of lxc.logfile
43ff9c6 
Closes #3369

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
matthijskooijman added a commit to matthijskooijman/Tika that referenced this issue May 27, 2020
@matthijskooijman
lxc: Update configs to buster
c8fc70e 
Most conversion happened using lxc-update-config (after fixing
lxc/lxc#3369 manually).

On top of that, lxc.hook.version was set. Without this, info is passed
to hooks as arguments, but the argument order had changed, so the hook
needed to be adapted. With lxc.hook.version set to 1, info is passed in
environment variables, which is more future-proof.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lxc-update-config: Fix bad handling of lxc.logfile stgraber/lxc
2 participants
@matthijskooijman @stgraber