Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conf.c: HAVE_LIBCAP #3612

Closed
thedolphin opened this issue Dec 30, 2020 · 1 comment
Closed

conf.c: HAVE_LIBCAP #3612

thedolphin opened this issue Dec 30, 2020 · 1 comment
Labels
Bug Confirmed to be a bug Easy Good for new contributors

Comments

@thedolphin
Copy link

include of sys/capabilities.h depends on HAVE_LIBCAP
but CAP_NET_ADMIN is used later regardless of HAVE_LIBCAP and this leads to error

conf.c:654:38: error: use of undeclared identifier 'CAP_NET_ADMIN'
        bool has_cap_net_admin = in_caplist(CAP_NET_ADMIN, &conf->caps);
@stgraber stgraber added Bug Confirmed to be a bug Easy Good for new contributors labels Dec 30, 2020
@stgraber
Copy link
Member

Looks like an easy fix for anyone who wants it.
I think it may be a recent regression too.

brauner pushed a commit that referenced this issue Jan 6, 2021
macro: define all capabilities
1865b64 
Fixes: #3612
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed to be a bug Easy Good for new contributors
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thedolphin @stgraber