Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc-test-fuzzers is broken #4261

Closed
hallyn opened this issue Jan 18, 2023 · 6 comments
Closed

lxc-test-fuzzers is broken #4261

hallyn opened this issue Jan 18, 2023 · 6 comments

Comments

@hallyn
Copy link
Member

hallyn commented Jan 18, 2023

The template below is mostly useful for bug reports and support questions.
Feel free to remove anything which doesn't apply to you and add more information where it makes sense.

Required information

  • Distribution: Ubuntu
  • Distribution version: 22.04
  • The output of
    • lxc-start --version
    • lxc-checkconfig
    • uname -a
    • cat /proc/self/cgroup
    • cat /proc/1/mounts

Issue description

lxc-test-fuzzers is broken:

serge@jerom ~/src/lxc/src/tests$ ./lxc-test-fuzzers

  • set -o pipefail
    ++ mktemp -d

  • TMP_DIR=/tmp/tmp.vq7l35MsvZ

  • export ASAN_OPTIONS=detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:strict_string_checks=1

  • ASAN_OPTIONS=detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:strict_string_checks=1

  • export UBSAN_OPTIONS=print_stacktrace=1:print_summary=1:halt_on_error=1

  • UBSAN_OPTIONS=print_stacktrace=1:print_summary=1:halt_on_error=1

  • trap cleanup exit

  • for fuzzer in /usr/bin/fuzz-lxc-*
    ++ basename '/usr/bin/fuzz-lxc-*'

  • name='fuzz-lxc-*'

  • corpus_dir='/tmp/tmp.vq7l35MsvZ/fuzz-lxc-*'

  • mkdir -p '/tmp/tmp.vq7l35MsvZ/fuzz-lxc-*'

  • wget --directory-prefix=/tmp/tmp.vq7l35MsvZ 'https://storage.googleapis.com/lxc-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/lxc_fuzz-lxc-*/public.zip'
    Warning: wildcards not supported in HTTP.
    --2023-01-18 11:56:15-- https://storage.googleapis.com/lxc-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/lxc_fuzz-lxc-*/public.zip
    Resolving storage.googleapis.com (storage.googleapis.com)... 2607:f8b0:4023:1009::80, 2607:f8b0:4023:1006::80, 2607:f8b0:4023:1000::80, ...
    Connecting to storage.googleapis.com (storage.googleapis.com)|2607:f8b0:4023:1009::80|:443... connected.
    HTTP request sent, awaiting response... 403 Forbidden
    2023-01-18 11:56:15 ERROR 403: Forbidden.

  • '/usr/bin/fuzz-lxc-' -max_total_time=120 '/tmp/tmp.vq7l35MsvZ/fuzz-lxc-'
    ./lxc-test-fuzzers: line 24: /usr/bin/fuzz-lxc-*: No such file or directory

  • cleanup

  • rm -rf /tmp/tmp.vq7l35MsvZ

Looks like the URL needs to be updated.

@hallyn
Copy link
Member Author

hallyn commented Jan 18, 2023

@evverx @diederikdehaas Do you know offhand what should be the new location?

@evverx
Copy link
Contributor

evverx commented Jan 18, 2023

Looks like the fuzz targets are no longer installed to /usr/bin. I think this script can be safely removed because that local fuzzing infrastructure was removed when lxc switched to meson. CIFuzz runs the fuzz targets with those corpora on every PR these days anyway.

@diederikdehaas
Copy link
Contributor

@hallyn maybe you tried to get someone else's attention?

@hallyn
Copy link
Member Author

hallyn commented Jan 18, 2023

@hallyn maybe you tried to get someone else's attention?

Could be - apologies if so. I was looking at the changelog which listed Signed-off-by: Diederik de Haas didi.debian@cknow.org

@hallyn
Copy link
Member Author

hallyn commented Jan 18, 2023

(but I do see that it was not actually relevant to the test itself, so in any case a bad callout. Sorry)

@diederikdehaas
Copy link
Contributor

No worries :)
I did make changes, but that was without knowing or understanding the full tests. So I can't provide any useful input here.

stgraber pushed a commit that referenced this issue Jan 25, 2023
Closes #4261

Signed-off-by: Serge Hallyn <serge@hallyn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants