Unable to build v6.0.0 with nix #4427
Assignees
Comments
13 tasks
|
Thanks for your report! This is really odd issue. I have tried to play with NixOS a bit but it has very unusual build environment. Couldn't you provide some clear steps how I can reproduce the issue with local LXC source tree? If I had this local environment I would be able to experiment with it a bit and try to tackle down the problem. The reproducer that you've shown is about getting sources directly from github/NixOS servers AFAIU. |
|
Hi @mihalicyn You can use either nixos (e.g. the incus image) or another distro with nix installed. Assuming the basic incus nixos image: nix-env -iA nixos.git
git clone https://github.com/lxc/lxc -b v6.0.0
cd lxc
nix --refresh --extra-experimental-features 'flakes nix-command' develop github:nixos/nixpkgs?ref=refs/pull/301564/head#lxc
# you'll now in be in a shell with all needed dependencies that match our build environment
meson setup build
meson compile -C buildYou'll get the same errors here. |
mihalicyn
added a commit
to mihalicyn/lxc
that referenced
this issue
Apr 5, 2024
Fixes: lxc#4427 Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
|
Huge thanks, Adam! I have posted a PR with fix. |
|
I wonder if this fix should be shipped for every distribution? Or does it matter if the lxc was successfully built? |
|
Hi, i have the same issue in the Funtoo/Macaroni OS ebuild. |
mihalicyn
added a commit
to mihalicyn/lxc
that referenced
this issue
Apr 6, 2024
Fixes: lxc#4427 Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
|
Dear friends, really sorry for making troubles for you with this. I have just updated my PR (#4428) with fix for this. @geaaru Daniele, couldn't you check that fix from PR #4428 works for you too on Gentoo/Funtoo/Macaroni OS? @juippis no, if it builds, it builds. It does not matter if LXC builds successfully. There is no security or any other risks. It's just a matter of different versions of GCC/ld/meson and distro-specific configuration for this tool-chain. |
|
@mihalicyn hi, with your fix I haven't resolved the problem from my side. It compiles without your patch too, only when i use So, with |
|
Just another note... if I remove |
|
It's interesting. Have tried with Gentoo: This configuration: builds without any errors... I'm on the way to try with Funtoo. |
|
Ok, tried with Funtoo. The same. builds just fine. @geaaru any suggestions how to reproduce this? |
|
#4428 did fix non-multicall for nix, but multicall still fails with setting |
|
@mihalicyn hi, unlucky the current Incus images are related to Funtoo 1.4 EOL. The Funtoo Next images were disabled a few months ago for an issue with DHCP. I need to look at this to drop those images and restore funtoo Next. |
|
I fear that could depend on something with sandbox container.... just try to compile it directly from the repo works, but using |
|
@mihalicyn Sorry, I'm a bit busy these days, I will try to share a way to reproduce my issues next weekend. |
No problem. I'm a bit busy too right now, but I'll try to address this issue on this week. |
|
Sorry for the delay. With these steps I can reproduce the issue every time with both multicall or without multicall mode. $> docker run --rm -ti macaronios/phoenix-minimal-devel:latest-amd64
$> anise repo update
$> anise i -y meta-repo meta-geaaru-kit binutils sys-devel-2.69/autoconf m4 automake gcc-config git diffutils baselayout meson ninja linux-headers libseccomp pkgconf gperf re2c pkgconfig cython wget ca-certificates dbus portage
$> gcc-config 1
$> source /etc/profile
$> cd /var/git/extra-kits/geaaru-kit
$> git checkout funtoo
$> git pull -ff
$> export FEATURES="-sandbox -usersandbox -ipc-sandbox -pid-sandbox -network-sandbox"
$> # without multicall
$> USE="lto " emerge lxc --nodeps
$> # with multicall
$> USE="lto tools-multicall" emerge lxc --nodeps If I compile with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
Hi, I'm trying to upgrade the nixpkgs package to v6.0.0 but I'm currently stuck due to changes which have broken our build's ability to link. Whether using multi-binary or tools-multicall, the only way I've found to build v6.0 is by reverting #4401.
Steps to reproduce
https://github.com/adamcstephens/nixpkgs/blob/lxc/6/pkgs/by-name/lx/lxc/generic.nix
The text was updated successfully, but these errors were encountered: