Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete build options for Pthread API #84

Closed
elfring opened this issue Oct 28, 2013 · 7 comments
Closed

Complete build options for Pthread API #84

elfring opened this issue Oct 28, 2013 · 7 comments
Labels
Feature New feature, not a bug
Milestone

Comments

@elfring
Copy link
Contributor

elfring commented Oct 28, 2013

Would you like to add the configuration script "AX_PTHREAD" to your build specification?

@hallyn
Copy link
Member

hallyn commented Nov 14, 2013

Thanks, this sounds worth doing.

@elfring
Copy link
Contributor Author

elfring commented Nov 28, 2017

Please reopen this issue until the additional macro call will be correctly used.

@brauner
Copy link
Member

brauner commented Nov 28, 2017

@elfring?

@elfring
Copy link
Contributor Author

elfring commented Nov 28, 2017

@brauner, @marcosps: I suggest to pass additional parameters for the call of the macro “AX_PTHREAD”.

@brauner
Copy link
Member

brauner commented Nov 28, 2017

When you claim "correctly used" it would be nice to know what you mean by that. What parameters are you referring to and would you be up for sending a patch?

@marcosps
Copy link
Contributor

@elfring I left the AX_PTHREAD without any additional parameters because AC_SEARCH_LIBS wasn't using anything too. What do you suggests to do in this case?

@elfring
Copy link
Contributor Author

elfring commented Nov 28, 2017

How do you think about an update suggestion like the following?

 # Check for some libraries
-AX_PTHREAD
+AX_PTHREAD([LIBS="$PTHREAD_LIBS $LIBS"
+CFLAGS="$CFLAGS $PTHREAD_CFLAGS"
+CC="$PTHREAD_CC"],
+           [AC_MSG_ERROR([Could not configure POSIX threads support])])
 AC_SEARCH_LIBS(clock_gettime, [rt])

brauner pushed a commit that referenced this issue Dec 15, 2017
Closes: #84

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
brauner pushed a commit that referenced this issue Dec 17, 2017
Closes: #84

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
brauner pushed a commit that referenced this issue Feb 7, 2018
Closes: #84

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, not a bug
Development

No branches or pull requests

5 participants