setns instead of unshare in lxc-attach #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request didn't trigger Jenkins as its author isn't in the whitelist. An organization member must perform one of the following:
Those commands are simple Github comments of the format: "jenkins: COMMAND" |
| @@ -932,7 +931,7 @@ int lxc_attach(const char* name, const char* lxcpath, lxc_attach_exec_t exec_fun | |||
| } | |||
|
|
|||
| if (options->attach_flags & LXC_ATTACH_MOVE_TO_CGROUP && cgns_supported()) | |||
| unshare_cgns = true; | |||
| options->namespaces = options->namespaces | CLONE_NEWCGROUP; | |||
There was a problem hiding this comment.
Could you please rewrite this to:
options->namespaces |= CLONE_NEWCGROUP;
|
Oh, and please name your commit |
lxc-checkpoint will fail because process createdy by lxc-attach has incorrect cgroup ns. It needs to use "setns" instead of "unshare" to set cgroup ns. Signed-off-by: Chen Haiquan <oc@yunify.com>
|
jenkins: test this please |
z-image
pushed a commit
to z-image/lxc
that referenced
this pull request
Oct 16, 2016
attach: use setns instead of unshare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process created by lxc-attach has incorrect cgroup ns. It fails lxc-checkpoint as reported in criu issue.
A real example for this issue, which is used to update ip address:
lxc-checkpoint will fail because dhclient process has incorrect cgroup ns. It needs to use setns instead of unshare to set cgroup ns. "setns" already supports cgroup ns in kernel of ubuntu 16.04.