Rcfile as common arg #1122
Merged
Rcfile as common arg #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request didn't trigger Jenkins as its author isn't in the whitelist. An organization member must perform one of the following:
Those commands are simple Github comments of the format: "jenkins: COMMAND" |
|
jenkins: test this please |
1 similar comment
|
jenkins: test this please |
Blub
force-pushed
the
rcfile-as-common-arg
branch
from
1ccfe60
to
68605bc
Compare
|
Changes in the update:
and rebased to current master |
|
jenkins: test this please |
2 similar comments
|
jenkins: test this please |
|
jenkins: test this please |
In almost all commands it's a useful addition to the -n switch which is a common option, too. Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
In order to cause c->is_defined() to become true. Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
It doesn't have any effect on what lxc-top does and is only accepted on account of being part of the common option list. Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Blub
force-pushed
the
rcfile-as-common-arg
branch
from
68605bc
to
6f94152
Compare
|
Changes in the update: |
|
jenkins: test this please |
z-image
pushed a commit
to z-image/lxc
that referenced
this pull request
Oct 16, 2016
Rcfile as common arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put the
c->configfilechange into a separate commit - I'm unsure whether it would be a better idea to add a call for that or even letc->load_config()handle this, but that could be a potentially breaking change for some library users, so for now I went with just setting it directly.