tools: exit with return code of lxc_execute() #1432
Conversation
|
Looks like your fix revealed that we had a failing test on clang related to availability of the gnutls library. |
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2017-02-15/fix_lxc_execute_return_code
branch
from
509c7f8
to
7dbcfe7
Compare
|
Looks correct to me. |
|
Should a test that would catch this be added? |
|
jenkins: test this please. |
|
@glennpratt, up for writing that patch? |
|
@brauner I gave it a quick shot by adding a script under src/tests... but I don't know how to run the tests. I see mentions in the Jenkins console output, but I don't know what |
|
Jenkins: test this please |
|
@brauner I don't see how throwing this back at Jenkins would fix anything :) The problem is clearly that init inside the test container doesn't appear to be static, causing it to fail and so exit non-zero. In the past this issue was papered over by this bug, making the test pass despite the binary failing. We need to figure out why that init build isn't static and fix that, or if it's not possible to have a static clang build, then adapt the test, to either work with the dynamic one or just be skipped. |
|
Yeah, I just wanted to make sure that this wasn't a temporary failure. |
|
Hi, I'm finding that changing -static to -all-static in src/lxc/Makefile.am, I.e. -init_lxc_static_LDFLAGS = -static fixes it for me. Can you try that? |
|
@hallyn, pushing a commit on top of my branch and including your signed-off by. |
Signed-off-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Christian Brauner christian.brauner@ubuntu.com
Closes #1431.