network: don't delete net devs we didn't create #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we didn't create a net dev we should make sure that we don't delete it. We can simply check whether we have index for it. If not, we didn't create it. Closes lxc#1600. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2017-05-30/veth_fixes
branch
from
0d5fbdb
to
b316d20
Compare
|
Hmm, so that sounds right in general. We may need to take a look at potential implications for LXD though as I don't think that LXD deletes the devices it adds to the container after it started. |
|
@stgraber, wait, if LXD adds devices to the container after it started, how would LXC know about them and delete them? |
|
Unless you add them via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we didn't create a net dev we should make sure that we don't delete it. We
can simply check whether we have index for it. If not, we didn't create it.
Closes #1600.
Signed-off-by: Christian Brauner christian.brauner@ubuntu.com