conf: ret-try devpts mount without gid=5 on error #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always default to mounting devpts with gid=5 but we should fallback to mounting without gid=5. This let's us cover use-cases such as container started with only a single mapping e.g.: lxc.idmap = u 1000 1000 1 lxc.idmap = g 1000 1000 1 Closes lxc#2257. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2018-04-12/bugfixes
branch
from
d222b84
to
03fc955
Compare
hallyn
reviewed
Apr 12, 2018
| return -1; | ||
| } | ||
|
|
||
| fclose(pathfile); |
There was a problem hiding this comment.
You are leaking the fd returned by open(O_CREATE) here.
There was a problem hiding this comment.
Oh, I didn't push the fixed version yet. :( Sorry.
There was a problem hiding this comment.
The fixed version abuses mknod() ;)
When starting application containers without a mapping for container root are started, a dummy bind-mount target for lxc-init needs to be created. This will not always work directly under "/" when e.g. permissions are missing due to the ownership and/or mode of "/". We can try to work around this by using the P_tmpdir as defined in POSIX which should usually land us in /tmp where basically everyone can create files. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2018-04-12/bugfixes
branch
from
03fc955
to
794248d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always default to mounting devpts with gid=5 but we should fallback
to mounting without gid=5. This let's us cover use-cases such as container
started with only a single mapping e.g.:
lxc.idmap = u 1000 1000 1
lxc.idmap = g 1000 1000 1
Closes #2257.
Signed-off-by: Christian Brauner christian.brauner@ubuntu.com