BASH Completions rename not fully propagated #2336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request didn't trigger Jenkins as its author isn't in the whitelist. An organization member must perform one of the following:
Those commands are simple Github comments of the format: "jenkins: COMMAND" |
|
Hi Molly Jo,
I ran into similar problem. Maybe this post will help.
https://discuss.linuxcontainers.org/t/lxc-source-build-problem-on-redhat-7-4/1448/14
HTH Gilbert
…On Fri, May 18, 2018 at 11:36 AM, MollyJoBault ***@***.***> wrote:
Running on both the master and on the stable-2.0, I couldn't run "make
rpm". I would get the following error:
Processing files: lxc-2.0.9-1.el7.centos.x86_64
error: File not found: /home/user/rpmbuild/BUILDROOT/lxc-2.0.9-1.el7.centos.x86_64/etc/bash_completion.d
I tried commending out the lxc.spec.in line and I got:
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/user/rpmbuild/BUILDROOT/lxc-2.0.9-1.el7.centos.x86_64
error: Installed (but unpackaged) file(s) found:
/usr/share/bash-completion/completions/lxc
The fix was to fix the naming. RPM building now working for CentOS.
------------------------------
You can view, comment on, or merge this pull request online at:
#2336
Commit Summary
- fixed_bash_completions_for_rpm
File Changes
- *M* configure.ac <https://github.com/lxc/lxc/pull/2336/files#diff-0>
(2)
- *M* lxc.spec.in <https://github.com/lxc/lxc/pull/2336/files#diff-1>
(2)
Patch Links:
- https://github.com/lxc/lxc/pull/2336.patch
- https://github.com/lxc/lxc/pull/2336.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2336>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJgU4eOdR5qFReiJ1kjj3_gv48qV0Kn3ks5tzviGgaJpZM4UFBrX>
.
--
Gilbert Standen
Creator Orabuntu-LXC
914-261-4594
gilbert@orabuntu-lxc.com
|
|
Hi Molly Jo,
Your solution to change the naming looks pretty cool. I will try it out
also and see if it works for me as well and update this issue with
results. It's a much better solution than what I have I think.
Thanks,
Gilber
…On Fri, May 18, 2018 at 11:36 AM, MollyJoBault ***@***.***> wrote:
Running on both the master and on the stable-2.0, I couldn't run "make
rpm". I would get the following error:
Processing files: lxc-2.0.9-1.el7.centos.x86_64
error: File not found: /home/user/rpmbuild/BUILDROOT/lxc-2.0.9-1.el7.centos.x86_64/etc/bash_completion.d
I tried commending out the lxc.spec.in line and I got:
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/user/rpmbuild/BUILDROOT/lxc-2.0.9-1.el7.centos.x86_64
error: Installed (but unpackaged) file(s) found:
/usr/share/bash-completion/completions/lxc
The fix was to fix the naming. RPM building now working for CentOS.
------------------------------
You can view, comment on, or merge this pull request online at:
#2336
Commit Summary
- fixed_bash_completions_for_rpm
File Changes
- *M* configure.ac <https://github.com/lxc/lxc/pull/2336/files#diff-0>
(2)
- *M* lxc.spec.in <https://github.com/lxc/lxc/pull/2336/files#diff-1>
(2)
Patch Links:
- https://github.com/lxc/lxc/pull/2336.patch
- https://github.com/lxc/lxc/pull/2336.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2336>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJgU4eOdR5qFReiJ1kjj3_gv48qV0Kn3ks5tzviGgaJpZM4UFBrX>
.
--
Gilbert Standen
Creator Orabuntu-LXC
914-261-4594
gilbert@orabuntu-lxc.com
|
|
@gstanden I think you are experiencing a different problem than what I have here. :) |
|
@MollyJoBault Yes that's right that long thread that I referenced was
covering a couple different issues with the RPM build, but my workaround
for the bash_completion.d issue is in that thread I referenced also. The
fix I have been using for the bash_completion.d problem is in that thread
and is this:
quote from the thread:
"Can also get a successful build by adding this line under %install
(instead of commenting out the lines as mentioned above) in the lxc.spec
file:
install -m 755 -d $RPM_BUILD_ROOT%{_sysconfdir}/bash_completion.d
"
This was the workaround I was using until now, but I will give your fix a
try thanks!
…On Fri, May 18, 2018 at 1:38 PM, MollyJoBault ***@***.***> wrote:
@gstanden <https://github.com/gstanden> I think you are experiencing a
different problem than what I have here. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2336 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJgU4eAGgiRmqqys2YuZPg4pDbTgSxbHks5tzxUlgaJpZM4UFBrX>
.
--
Gilbert Standen
Creator Orabuntu-LXC
914-261-4594
gilbert@orabuntu-lxc.com
|
|
Also, fwiw, in some cases unpackaged files terminating the rpm build can be
handled this way, in cases where the unpackaged file error is not
catastrophic to functionality, such as in the case of bash_completions.
This method is just another way to workaround the problem:
sudo sh -c "echo '%_unpackaged_files_terminate_build 0' >> /etc/rpm/macros"
…On Fri, May 18, 2018 at 1:38 PM, MollyJoBault ***@***.***> wrote:
@gstanden <https://github.com/gstanden> I think you are experiencing a
different problem than what I have here. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2336 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJgU4eAGgiRmqqys2YuZPg4pDbTgSxbHks5tzxUlgaJpZM4UFBrX>
.
--
Gilbert Standen
Creator Orabuntu-LXC
914-261-4594
gilbert@orabuntu-lxc.com
|
|
This PR should be made against master and it should be signed-off. :) |
|
I'm closing this but we'd merge this if there's PR against master and it is signed-off. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on both the master and on the stable-2.0, I couldn't run "make rpm". I would get the following error:
I tried commending out the lxc.spec.in line and I got:
The fix was to fix the naming. RPM building now working for CentOS.