Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instantiation of multiple vlan interfaces with same id #397

Merged
merged 1 commit into from Jan 21, 2015

Conversation

axn
Copy link

@axn axn commented Jan 13, 2015

Container fail to start with configs (as shown below) where the same
vlan id is used for several type=vlan container interfaces.
Then, during the instantiation of the vlan interfaces, an error occurs
because the lxc code tries to assign the same temporary name to both
of them before it is bound into the container.

lxc.network.type = vlan
lxc.network.flags = up
lxc.network.link = eth1
lxc.network.vlan.id = 3842
lxc.network.name = iso0

lxc.network.type = vlan
lxc.network.flags = up
lxc.network.link = eth2
lxc.network.vlan.id = 3842
lxc.network.name = iso1

Signed-off-by: Axel Neumann neumann@cgws.de

Container fail to start with configs (as shown below) where the same
vlan id is used for several type=vlan container interfaces.
Then, during the instantiation of the vlan interfaces, an error occurs
because the lxc code tries to assign the same temporary name to both
of them before it is bound into the container.

> lxc.network.type      = vlan
> lxc.network.flags     = up
> lxc.network.link      = eth1
> lxc.network.vlan.id   = 3842
> lxc.network.name      = iso0
>
> lxc.network.type      = vlan
> lxc.network.flags     = up
> lxc.network.link      = eth2
> lxc.network.vlan.id   = 3842
> lxc.network.name      = iso1

Signed-off-by: Axel Neumann <neumann@cgws.de>
@axn
Copy link
Author

axn commented Jan 13, 2015

The problem and fix has also been discussed in lxc-devel mailing list some time ago :-)
https://lists.linuxcontainers.org/pipermail/lxc-devel/2012-July/002584.html

@hallyn
Copy link
Member

hallyn commented Jan 21, 2015

Thanks for the reminder. Merging

hallyn added a commit that referenced this pull request Jan 21, 2015
Fix instantiation of multiple vlan interfaces with same id
@hallyn hallyn merged commit 6b1aa94 into lxc:master Jan 21, 2015
z-image pushed a commit to z-image/lxc that referenced this pull request Oct 16, 2016
Fix instantiation of multiple vlan interfaces with same id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants