Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc_storage_prepare(): Fix ephemeral copies #4344

Merged
merged 1 commit into from
Nov 29, 2023
Merged

lxc_storage_prepare(): Fix ephemeral copies #4344

merged 1 commit into from
Nov 29, 2023

Conversation

gibmat
Copy link
Contributor

@gibmat gibmat commented Sep 1, 2023

It appears that rootfs->bdev_type wasn't actually being set anywhere, other than if it comes from a config file.

Fixes: #4199

@lxc-jenkins
Copy link

This pull request didn't trigger Jenkins as its author isn't in the allow list.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@jcharaoui
Copy link

I've tested this change on my Debian 12 system and it works. Thank you!

@hallyn
Copy link
Member

hallyn commented Sep 4, 2023

jenkins: ok to test

hallyn
hallyn approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@hallyn hallyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

brauner
brauner reviewed Sep 4, 2023
View reviewed changes
src/lxc/conf.c Outdated Show resolved Hide resolved
@gibmat
Copy link
Contributor Author

gibmat commented Sep 15, 2023

If possible I'd like to have a fix for creating ephemeral containers (either my change proposed in this pull request, or perhaps a better solution) included in the Debian 12.2 point release (scheduled for Oct 7). Working back from that date, I need to have the updated package basically ready by the 23rd so there's plenty of time for the update to be approved and included by the release team.

@stgraber
Copy link
Member

@brauner

@gibmat
Copy link
Contributor Author

gibmat commented Nov 23, 2023

@stgraber @brauner quick ping on this again -- Debian has another point release coming up on December 9.

@stgraber
Copy link
Member

jenkins: test this please

@lxc-jenkins
Copy link

Testsuite passed

@brauner brauner self-assigned this Nov 29, 2023
@brauner
conf: fix ephemeral copies
0e93281 
Don't rely on rootfs->bdev_type because that may be NULL. Use storage->type
instead which can't be NULL.

Co-Developed-by: Mathias Gibbens <gibmat@debian.org>
Signed-off-by: Mathias Gibbens <gibmat@debian.org>
Reported-by: Mathias Gibbens <gibmat@debian.org>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@lxc-jenkins
Copy link

Testsuite passed

1 similar comment
@lxc-jenkins
Copy link

Testsuite passed

@stgraber stgraber merged commit a6608b8 into lxc:main Nov 29, 2023
8 checks passed
@gibmat gibmat deleted the fix-ephemeral-copy branch November 30, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brauner brauner brauner left review comments

@hallyn hallyn hallyn approved these changes

Assignees

@brauner brauner

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lxc_rootfs_init attempts to pin overlayfs due to rootfs->bdev_type == NULL
6 participants
@gibmat @lxc-jenkins @jcharaoui @hallyn @stgraber @brauner