Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instanced systemd service #577

Merged
merged 1 commit into from Aug 13, 2015
Merged

Add instanced systemd service #577

merged 1 commit into from Aug 13, 2015

Conversation

CameronNemo
Copy link
Contributor

No description provided.

@stgraber
Copy link
Member

stgraber commented Jul 1, 2015

Can you edit your commit message to contain the required Signed-off-by string (per CONTRIBUTING.md)?

Thanks!

Signed-off-by: Cameron Norman <camerontnorman@gmail.com>
@CameronNemo
Copy link
Contributor Author

Done. Sorry about that :)

@stgraber
Copy link
Member

stgraber commented Jul 1, 2015

so shouldn't there be something in the main lxc.service unit to trigger the lxc@ unit for all auto-started containers?

@stgraber
Copy link
Member

@CameronNemo ping

@CameronNemo
Copy link
Contributor Author

Sorry, meant to get back then it slipped my mind.

My intention was to support both separately so someone could use the lxc-autostart interface or just enable lxc@foo.service with systemd. Having lxc.service call out to lxc@.service would be a little harder, especially since I know it is not recommended to run systemctl start, stop, etc. as part of a systemd service because it is prone to deadlocks...

I think that this is ok to merge for now, and if somebody wants to do the work to make lxc.service call lxc@.service then that can be done later on.

If you do not want to merge without that, then I can just close the PR and re-open when I find time to test it out thoroughly to ensure there are no deadlock issues.

stgraber added a commit that referenced this pull request Aug 13, 2015
@stgraber stgraber merged commit f2a7f2a into lxc:master Aug 13, 2015
z-image pushed a commit to z-image/lxc that referenced this pull request Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants