Check if the stdout is a terminal in lxc-checkconfig #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request didn't trigger Jenkins as its author isn't in the whitelist. An organization member must perform one of the following:
Those commands are simple Github comments of the format: "jenkins: COMMAND" |
|
That looks quite reasonable, however you need to sign-off your commit before we can accept it. Please edit your commit message to include the required "Signed-off-by" line (see CONTRIBUTING). |
Let lxc-checkconfig write to non-tty stdout without color control characters Signed-off-by: walkerning <foxdoraame@gmail.com>
|
@stgraber Sorry for not check the CONTRIBUTING docs before PR. Now I signed off my commits~ |
z-image
pushed a commit
to z-image/lxc
that referenced
this pull request
Oct 16, 2016
Check if the stdout is a terminal in lxc-checkconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes me feel more convenient when reading a long
lxc-checkconfigoutput usinglessor redirecting thelxc-checkconfigoutput to file for sending to others.I don't know if you guys think this is necessary...