Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PCI support to incus info --resources #704

Closed
stgraber opened this issue Mar 29, 2024 · 4 comments · Fixed by #851
Closed

Add PCI support to incus info --resources #704

stgraber opened this issue Mar 29, 2024 · 4 comments · Fixed by #851
Assignees
@YuanSamuel
Labels
Easy Good for new contributors Feature New feature, not a bug
Milestone
incus-6.2

Comments

@stgraber
Copy link
Member

It would be good to have a generic PCI section in incus info --resources.

Similarly to #702, it should be pretty concise, just one line per device and look somewhat like lspci.

For each device, we should have:

  • Address
  • Vendor (name and id)
  • Product (name and id)
  • NUMA node
  • IOMMU group
  • Driver
@stgraber stgraber added Feature New feature, not a bug Easy Good for new contributors labels Mar 29, 2024
@stgraber stgraber added this to the soon milestone Mar 29, 2024
@YuanSamuel
Copy link

Hi! My partner and I are also a group from UT, would love to take this issue on if it's still up :)

@stgraber
Copy link
Member Author

stgraber commented Apr 1, 2024

Yep, I've assigned it to you!

@sharkman424
Copy link
Contributor

image
Do you want the driver or driver version (or both) reported?

@sharkman424 sharkman424 mentioned this issue May 7, 2024
Merged
stgraber pushed a commit to sharkman424/incus that referenced this issue May 7, 2024
@sharkman424 @stgraber
incus/info: Add PCI devices to --resources
533a647 
Closes lxc#704

Signed-off-by: sharkman424 <joshuadierker@gmail.com>
@stgraber
Copy link
Member Author

stgraber commented May 7, 2024

Just driver is fine, version is rarely useful.

@stgraber stgraber modified the milestones: soon, incus-6.2 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuanSamuel YuanSamuel

Labels
Easy Good for new contributors Feature New feature, not a bug
Milestone
incus-6.2
Development

Successfully merging a pull request may close this issue.

Add PCI support to incus info --resources sharkman424/incus
3 participants
@stgraber @sharkman424 @YuanSamuel