Fix memory hog during image import #245
Conversation
This adds basic support for storage pools as well as tests to verify their function, taken from the LXD REST API.
memory. requests-toolbetl external package required as embedded to requests multipart 'files' based upload still load parts to memory.
memory. requests-toolbetl external package required as embedded to requests multipart 'files' based upload still load parts to memory.
Add support for LXD storage pools
This adds support for LXD being installed via snap in addition to the traditional apt package. Fixes canonical#248
This reverts commit 598590d.
This reverts commit 060bb3c.
This reverts commit 738ab03.
This reverts commit be4f5dc.
|
I think the tests are failing because your branch is behind master. Please could you rebase your branch against pylxd/master and we can see if the tests will pass. Thanks. |
Allow pylxd to work with snap installed lxd as well as normally installed lxd from packages. This is needed as the unixsocket is inside the snap at /var/snap/lxd/common/lxd/unix.socket.
Include created_at attribute for the snapshot object.
memory. requests-toolbetl external package required as embedded to requests multipart 'files' based upload still load parts to memory.
memory. requests-toolbetl external package required as embedded to requests multipart 'files' based upload still load parts to memory.
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 95.93% 96.14% +0.21%
==========================================
Files 14 15 +1
Lines 689 727 +38
Branches 78 81 +3
==========================================
+ Hits 661 699 +38
Misses 14 14
Partials 14 14
Continue to review full report at Codecov.
|
|
Rebased as requested. Now CI tests passed. |
|
Hi. It looks like something is wrong with the PR from a rebasing perspective. We're going to need to fix this PR before it can merge because it's showing commits that were made on master in your PR. Did you do a merge rather than a rebase? What we would like in the PR is just the changes that the PR wants to make to the master branch, which I think are quite small. It might be easiest to fix this, but closing the PR (but make sure you don't lose your work) and, re-branching from master, and re-applying your changes and doing a new PR? Thanks. |
|
Ok, new pull request created #252. This PR should be closed. |
Existing version load image into memory when non-unified image used
(with separate tarball with manifest).
Added ability for stream based image upload without loading them to memory.
requests-toolbelt external package required for streaming multipart HTTP
image upload.
Additional parameter added to identify if streams are/can be passed - this will allow
pylxd client to identify via introspection if pylxd library supports stream based
upload and fallback to old non-stream behavior if old version of pylxd is installed.