Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restore snapshot methods #357

Merged

Conversation

ajkavanagh
Copy link
Contributor

This patchset adds restore methods to the Container and Snapshot classes
to make it possible to restore a snapshot without having to use the
raw_api in pylxd.

Closes: #353

@ajkavanagh ajkavanagh force-pushed the add-restore-snapshot-method branch from b8ff627 to d276262 Compare May 1, 2019 14:47
@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #357 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   96.92%   96.94%   +0.02%     
==========================================
  Files          12       12              
  Lines        1008     1015       +7     
  Branches      113      114       +1     
==========================================
+ Hits          977      984       +7     
  Misses         12       12              
  Partials       19       19
Impacted Files Coverage Δ
pylxd/models/container.py 92.04% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b231c0a...40dc4dd. Read the comment docs.

@ajkavanagh ajkavanagh force-pushed the add-restore-snapshot-method branch from d276262 to 21e5a28 Compare May 1, 2019 15:12
This patchset adds restore methods to the Container and Snapshot classes
to make it possible to restore a snapshot without having to use the
raw_api in pylxd.

Closes: canonical#353
Signed-off-by: Alex Kavanagh <alex.kavanagh@canonical.com>
@ajkavanagh ajkavanagh force-pushed the add-restore-snapshot-method branch from 21e5a28 to c69e4eb Compare May 1, 2019 15:13
Signed-off-by: Alex Kavanagh <alex.kavanagh@canonical.com>
Copy link
Contributor

@ChrisMacNaughton ChrisMacNaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@ChrisMacNaughton ChrisMacNaughton merged commit 7794c86 into canonical:master May 3, 2019
@ajkavanagh ajkavanagh deleted the add-restore-snapshot-method branch May 3, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for restore snapshots
3 participants