New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up gesture recognizers #80
Conversation
I have the same issue, but your fix is not helping. I am setting this layout in Storyboard and then changing it dynamically and with your fix its still crashing. |
Do you have a demo project that demonstrate this? If you have I can review it. |
If you add to your example something like
It will crash then |
Noted. Thanks. Will give it a try and get back to you guys. |
@BartG , thank you, my first commit didn't fix the issue. |
I won't do that, feel free to contribute. |
@BartG That was what I was thinking as well. I was thinking of the following changes but some of it I'm currently not confident enough about them. I'm tagging LOW, MED, HIGH as an indication of my confidence level of each point.
|
@lxcid |
Thanks @myeyesareblind, didn't realise its your changes. I have pull from your repro and work on top of your changes. :) Could you help me review if this look good? My initial test seems to work. Let me know if you find any quirkiness. If all is well I'll merge to master and release a tag. /cc @BartG |
It's good |
Thanks for the help! Its merged! |
* commit '58b772eea6a38009cdfb8004398a864cae6cb231': [BUGFIX lxcid#80] Clean up gestures when collectionView property is nil'ed or layout is deallocated. really clean-up gesture recognizers clean up gesture recognizers Uses `- [CADisplayLink duration]` to calculate the distance to scroll. [Issue lxcid#49] Replaces `LX_rasterizedImage` with `LX_snapshotView` which attempts to use the iOS 7 snapshot function whenever possible. Fixed warnings in the example project when compiling for 64-bit architectures. Also, update a bit of the convention in the example project to be more modern and to my taste. :P Fixed bug of multiple cells on rapid tapping. # Conflicts: # LXReorderableCollectionViewFlowLayout/LXReorderableCollectionViewFlowLayout.m
I got a weird crash when I changed collectionViewFlowLayout dynamically.
Current version leaves gestures alive, so when the collectionView is tapped, gestureRecognizer will send message to zombie.