Building from source creates unusable .desktop file when grep 2.23 is installed.

[styrsven]

When grep 2.22 is installed the .desktop files are created correctly.
This has been discovered on a gentoo system, and found in at least
lxqt-base/lxqt-common-0.10.0
lxqt-base/lxqt-panel-0.10.0
x11-misc/pcmanfm-qt.0.10.0
x11-misc/obconf-qt-0.9.0_p20150729
lxqt-base/lxqt-session-0.10.0
lxqt-base/lxqt-config-0.10.0
lxqt-base/lxqt-powermanagement-0.10.0
lxqt-base/lxqt-notificationd-0.10.0
lxqt-base/lxqt-globalkeys-0.10.0
lxqt-base/lxqt-admin-0.10.0
lxqt-base/lxqt-about-0.10.0

I've attached samples showing bad (with grep 2.23) and good (with grep 2.22)

lxqt-desktop.desktop.bad.txt
lxqt-desktop.desktop.good.txt

[palinek]

@styrsven please, confirm that the lxqt/liblxqt@082321a fixes this issue on your side.

[styrsven]

Thanks, this fixed the issue for everything that depends on liblxqt. I guess this affects everything that have private copies of LXQtTranslateDesktop.cmake as well.

[rapgro]

👍 We need and use this patch in Fedora, too.

[styrsven]

Just remember there are separate copies of the file in compton.conf, libfm-qt, lximage-qt, obconf-qt and pcmanfm-qt. They need also to be updated.

[palinek]

@jleclanche @PCMan @luis-pereira @paulolieuthier @tsujan
Should I update all the components to use the translate* from liblxqt in build time?

[paulolieuthier]

Only lximage-qt. The others should keep lxqt-independent, AFAIK.

[palinek]

Only lximage-qt. The others should keep lxqt-independent, AFAIK.

And the reasoning?

I agree with @agaida - comment

[paulolieuthier]

Alright, I'm OK with build-dependency.

[pmattern]

Just in case someone stumbles upon this issue via searches or so:
The problem gets manifest only when some of (all?) the various environment variables LC_* are set to C. So an easy workaround is setting an arbitrary UTF-8 encoding as system-wide locale or value of LC_ALL when invoking cmake and make.

[palinek]

Why is this still open?

[agaida]

@palinek - i guess because of the build dependency thing - we should talk about after the release