Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from source creates unusable .desktop file when grep 2.23 is installed. #50

Closed
rapgro opened this issue Feb 14, 2016 · 8 comments

Comments

@rapgro
Copy link

rapgro commented Feb 14, 2016

Please use the cmake module directly from liblxqt and unbundle it. We suffer in Fedora from a bug with newer grep.
See lxqt/lxqt#957

@palinek
Copy link
Contributor

palinek commented Feb 14, 2016

I've submitted PR for this... but I don't know if others wish the liblxqt dependency...

@rapgro
Copy link
Author

rapgro commented Feb 14, 2016

Thanks. 👍

@rapgro rapgro closed this as completed Feb 14, 2016
@agaida agaida reopened this Feb 20, 2016
@agaida agaida closed this as completed Feb 20, 2016
@agaida
Copy link
Member

agaida commented Feb 20, 2016

See lxqt/lxqt#957
@palinek @PCMan @paulolieuthier @jleclanche
unfixed: compton-conf, libfm-qt, lximage-qt, obconf-qt and pcmanfm-qt
we should discuss it on the list if you agree - i see right now no downsides in a build-dependency, the resulting packages do not depend on liblxqt, because the pure cmake mechanics are used only at build time. Until we decide this we should push the '-a' thing into the packages.

BTW: the issue hit sid and will hit debian testing too soon and might affect all debian derivatives in a short amount of time

@agaida
Copy link
Member

agaida commented Feb 20, 2016

@ALL - the github bug tracking is horrible, we should really consider to use track or redmine for this

@luis-pereira
Copy link
Member

@agaida IIRC @PCMan pushed for not having an liblxqt compile dependency.

@agaida
Copy link
Member

agaida commented Feb 23, 2016

i'm fine with that too - but in that case we should build our own pkg-lxqt-tools with some arch indipendend scripts in it. In other words. a script is a script is a script - and if the scripting is indipendend enought it should be no problem to put it in a separated packages/repo and avoid code dupes

@rapgro
Copy link
Author

rapgro commented Feb 23, 2016

👍 for the independent scripts, what about in lxqt-common ?

@agaida
Copy link
Member

agaida commented Feb 23, 2016

@rapgro - i would not place build scripts in common. i would really pack them into a separated repo and make a package out of them. Hey - it's github, we don't have to pay per repository. Joke aside, its a lot easier to distribute if the scripts would be in a single package. A package with some internal used scripts is fast uploaded in case of changes and don't affect any users in case of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants