-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when your pokete runs out of all its AP #200
Comments
There are edge cases here which can result in you getting softlocked I think, if this is fixed. A solution should take the following three things into account:
All this logic should be abstracted into (is alive would be useful, for example, for making a pokete that can use a super charged attack with his dying breath maybe, getting 1 turn of immortality when he drops to 0 hp. That would also require a |
Also I triggered it again somehow but didn't run out of action points, I don't understand why. I'm gonna run in debug mode and see if I can see anything weird EDIT: maybe. I wasn't actually paying attention super well, and I just added 1 line which seems to have made it work and it did happen when I ran out of AP (minus fixing the softlock). So I might have a fix for this soon. |
Checklist
I have:
Describe the bug
Crash during a fight, I think before I lost.
To Reproduce
Steps to reproduce the behavior:
Haven't tried yet, but suspect it is due to running out of AP on all my (1) pokete that wasn't knocked out
You can see in the code near
fightmap.py:361
:That if the for loop comes up with no loser and the if does come up with a winner, then winner is not None but loser is None and the crash will happen
Expected behavior
no crash
Screenshots
The text was updated successfully, but these errors were encountered: