change save directory to ~/.local/share/pokete, and add migrate.sh to copy the data over #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… copy the data over using ~/.cache is bad because it can be cleared and people delete them sometimes
lxgr-linux
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Since it was requested here #137, I think it's a good idea to use the $XDG_DATA_HOME environment variable to determine the save location.
lxgr-linux
reviewed
Jun 15, 2022
Co-authored-by: lxgr-linux <64218491+lxgr-linux@users.noreply.github.com>
|
Thank you for your contribution. I would just like to have it fully backwards compatible, which means for me no user intervention required. |
|
Ready for review @MaFeLP |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a great idea to set it to
~/.cache, because this directory is supposed to be temporary and could be cleared every so often. People also sometimes clear it as it tends to get quite large over time.