Merge pull request #197 from creitiv/ignore-disabled-inputs

Ignore disabled form inputs
lxml · Aug 20, 2016 · 714b95c · 714b95c
2 parents 24b917e + bc6da1e
commit 714b95c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/lxml/html/__init__.py b/src/lxml/html/__init__.py
@@ -1019,7 +1019,7 @@ def form_values(self):
         results = []
         for el in self.inputs:
             name = el.name
-            if not name:
+            if not name or 'disabled' in el.attrib:
                 continue
             tag = _nons(el.tag)
             if tag == 'textarea':

diff --git a/src/lxml/html/tests/test_forms.txt b/src/lxml/html/tests/test_forms.txt
@@ -160,7 +160,7 @@ textarea_field: 'some text'
 >>> tree = lxml.html.fromstring('''
 ... <html><body>
 ...  <form>
-...   <input name="foo" value="bar"/>
+...   <input name="foo" value="bar" disabled/>
 ...   <input type="submit" />
 ...  </form>
 ... </body></html>
@@ -178,6 +178,8 @@ textarea_field: 'some text'
 >>> list(tree.forms[0].fields.values())
 ['bar']
 
+>>> ('foo', 'bar') not in tree.forms[0].form_values()
+True
 >>> tree = lxml.html.fromstring('''
 ... <html><body>
 ...  <form>