Fix setting the base url for etree.Resolver.resolve_string #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/GNOME/libxml2/blob/master/parserInternals.c#L1549 We seem to get away with only setting the _filename so that relative url's are resolved based on the value. Fixes https://bugs.launchpad.net/lxml/+bug/1568167
|
Thanks! |
|
A test would be nice, BTW. |
|
The file path might need encoding in some cases. I pushed a fix here: 5da090b |
|
Thanks, i'll add writing a unittest for this on my todo list :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/GNOME/libxml2/blob/master/parserInternals.c#L1549
We seem to get away with only setting the _filename so that relative
url's are resolved based on the value.
Fixes https://bugs.launchpad.net/lxml/+bug/1568167