Add option to prevent default doctypes #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason why this was added: mitmproxy/mitmproxy#845 See post on mailing list: https://mailman-mail5.webfaction.com/pipermail/lxml/2016-August/007738.html
|
Thanks |
|
Note, BTW, that I'm free to remove this option or render it disfunctional at any time, given that I won't be breaking any tests while doing that. ;-) |
|
@scoder I'm new to cython etc. and wanted to get some preliminary feedback before I delved into tests. I didn't really expect that it'll be merged so easily :P Do you want me to write some tests & create a new PR? |
|
Please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option to the
HTMLParserwhich passes out corresponding flag to libxml.There's another option
HTML_PARSE_NOIMPLIEDwhich is defined by libxml but we don't take it in as a parameter.Reason why this was added:
mitmproxy/mitmproxy#845
Post on mailing list:
https://mailman-mail5.webfaction.com/pipermail/lxml/2016-August/007738.html