fix html.SelectElement stripping whitespace from <option> values #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2017 12:36
This is a fix for bug #1665241, as the original fix for #399249 in 0b14af5 should not apply to option values, which are supposed to be passed through as-is.
|
Nice, thanks! |
|
Should I submit a PR for backporting it to the Also, Travis CI doesn't seem to be working although it seems to be configured -- is it disabled for some reason? |
|
While a bug-fix, this is also a change of long-standing behaviour that does not strictly belong into a 3.7.3. |
|
Fair enough. I've submitted a PR to scrapy to document this, as I encountered the problem while using it. |
nozayasu
pushed a commit
to nozayasu/scrapy
that referenced
this pull request
Mar 2, 2017
This can make the spider fail due to incorrect values being posted server-side, which is extremely hard to debug because it is easy to miss leading/trailing whitespace, even with a logging proxy. The fix was merged for lxml 3.8 in lxml/lxml#228 so document that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for bug #1665241. I've tried to add tests, please let me know if any changes need to be made.